This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Sensible way of selecting Prime member #5346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcio-diaz
reviewed
Mar 21, 2020
Co-Authored-By: Marcio Diaz <[email protected]>
marcio-diaz
approved these changes
Mar 23, 2020
kianenigma
approved these changes
Mar 23, 2020
Contributor
kianenigma
left a comment
kianenigma
left a comment
There was a problem hiding this comment.
removing the stake_of is also a good idea. It still exists in equlize though which we don't use.
Member
Author
|
@kianenigma Yeah it would be good to remove that when you get a chance - the staking code is made dramatically slower because of it as we don't cache on read - only on write, so every time you call |
bkchr
pushed a commit
that referenced
this pull request
Mar 24, 2020
* Calculate prime votes only during the election * Migration * Fix build, enable migration * Fix tests * Bump runtime version * Update frame/elections-phragmen/src/lib.rs Co-Authored-By: Marcio Diaz <[email protected]> Co-authored-by: Marcio Diaz <[email protected]>
rakanalh
pushed a commit
to rakanalh/substrate
that referenced
this pull request
Mar 25, 2020
* Calculate prime votes only during the election * Migration * Fix build, enable migration * Fix tests * Bump runtime version * Update frame/elections-phragmen/src/lib.rs Co-Authored-By: Marcio Diaz <[email protected]> Co-authored-by: Marcio Diaz <[email protected]>
20 tasks
apopiak
added
runtime-migration
and removed
A0-please_review
This was referenced Jun 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5290
This just uses Borda count for now.
This also combines the
StakeOfandVotesOfitems which were inexplicably separated, thus causing two trie ops when one was required.