Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@bkchr
Copy link
Member

@bkchr bkchr commented Sep 17, 2018

The macro currently does not support renaming of types. So only Module, Call, etc are required.

Progress on: #669

@bkchr bkchr requested a review from gavofyork September 17, 2018 08:31
Copy link
Member

@gavofyork gavofyork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@bkchr
Copy link
Member Author

bkchr commented Sep 17, 2018

@gavofyork now it also compiles :)

//! The Substrate runtime. This can be compiled with ``#[no_std]`, ready for Wasm.
#![cfg_attr(not(feature = "std"), no_std)]
#![recursion_limit="256"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please answer (prefferable leaving a comment), why it's increased (like what dependency requires it)?

) => {
mashup! {
$(
substrate_generate_config_name["config-name" $parsed_name] = $parsed_name Config;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few spaces

$(
substrate_generate_config_name["config-name" $parsed_name] = $parsed_name Config;
)*
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few spaces

@gavofyork gavofyork merged commit 8b7e552 into master Sep 17, 2018
@gavofyork gavofyork deleted the bkchr-construct_runtime_macro branch September 17, 2018 15:27
liuchengxu pushed a commit to chainx-org/substrate that referenced this pull request Aug 23, 2021
1. provide trait for xbitcoin_lockup
2. detect_lockup_type
3. handle_lockup_tx
4. reward pcx when deposit/issue success
5. reward to relayer
6. add set_token_name()
7. use `canwithdraw` replace withdraw blacklist
8.  improve fee for push_transaction
9. let lockuprelaytx use Vec<u8> in interface
10. fix some test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants