This repository was archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Implement construct_runtime! macro
#751
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This macro generates code for calling all the common `impl_outer_*` macros.
gavofyork
approved these changes
Sep 17, 2018
Member
gavofyork
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<3
Member
Author
|
@gavofyork now it also compiles :) |
pepyakin
reviewed
Sep 17, 2018
| //! The Substrate runtime. This can be compiled with ``#[no_std]`, ready for Wasm. | ||
| #![cfg_attr(not(feature = "std"), no_std)] | ||
| #![recursion_limit="256"] |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please answer (prefferable leaving a comment), why it's increased (like what dependency requires it)?
srml/support/src/runtime.rs
Outdated
| ) => { | ||
| mashup! { | ||
| $( | ||
| substrate_generate_config_name["config-name" $parsed_name] = $parsed_name Config; |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few spaces
srml/support/src/runtime.rs
Outdated
| $( | ||
| substrate_generate_config_name["config-name" $parsed_name] = $parsed_name Config; | ||
| )* | ||
| } |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few spaces
liuchengxu
pushed a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
1. provide trait for xbitcoin_lockup 2. detect_lockup_type 3. handle_lockup_tx 4. reward pcx when deposit/issue success 5. reward to relayer 6. add set_token_name() 7. use `canwithdraw` replace withdraw blacklist 8. improve fee for push_transaction 9. let lockuprelaytx use Vec<u8> in interface 10. fix some test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The macro currently does not support renaming of types. So only
Module,Call, etc are required.Progress on: #669