Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Remove necessity to pass ConsensusEngineId when registering notifications protocol #7549

Merged
6 commits merged into from
Nov 18, 2020
Merged

Remove necessity to pass ConsensusEngineId when registering notifications protocol #7549

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ff68f81
Remove necessity to pass ConsensusEngineId when registering notificat…
tomaka Nov 17, 2020
439809a
Line width
tomaka Nov 17, 2020
75062fc
Fix tests protocol name
tomaka Nov 18, 2020
b9c517e
Other renames
tomaka Nov 18, 2020
931b96b
Doc update
tomaka Nov 18, 2020
2a8b83b
Change issue in TODO
tomaka Nov 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix tests protocol name
  • Loading branch information
@tomaka
tomaka committed Nov 18, 2020
commit 75062fc21ba0376e06d0c2e08a27f405c1543c18
2 changes: 1 addition & 1 deletion client/network/src/gossip/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ fn build_test_full_node(config: config::NetworkConfiguration)
(service, event_stream)
}

const PROTOCOL_NAME: Cow<'static, str> = Cow::Borrowed("foo");
const PROTOCOL_NAME: Cow<'static, str> = Cow::Borrowed("/foo");

/// Builds two nodes and their associated events stream.
/// The nodes are connected together and have the `PROTOCOL_NAME` protocol registered.
Expand Down
2 changes: 1 addition & 1 deletion client/network/src/service/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ fn build_test_full_node(config: config::NetworkConfiguration)
(service, event_stream)
}

const PROTOCOL_NAME: Cow<'static, str> = Cow::Borrowed("foo");
const PROTOCOL_NAME: Cow<'static, str> = Cow::Borrowed("/foo");

/// Builds two nodes and their associated events stream.
/// The nodes are connected together and have the `PROTOCOL_NAME` protocol registered.
Expand Down