Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Remove necessity to pass ConsensusEngineId when registering notifications protocol #7549

Merged
6 commits merged into from
Nov 18, 2020
Merged

Remove necessity to pass ConsensusEngineId when registering notifications protocol #7549

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ff68f81
Remove necessity to pass ConsensusEngineId when registering notificat…
tomaka Nov 17, 2020
439809a
Line width
tomaka Nov 17, 2020
75062fc
Fix tests protocol name
tomaka Nov 18, 2020
b9c517e
Other renames
tomaka Nov 18, 2020
931b96b
Doc update
tomaka Nov 18, 2020
2a8b83b
Change issue in TODO
tomaka Nov 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Doc update
  • Loading branch information
@tomaka
tomaka committed Nov 18, 2020
commit 931b96bd9ac2d1d42d40decb3bbbf31cd53f4018
2 changes: 1 addition & 1 deletion client/network-gossip/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
//! - Implement the `Network` trait, representing the low-level networking primitives. It is
//! already implemented on `sc_network::NetworkService`.
//! - Implement the `Validator` trait. See the section below.
//! - Decide on a `ConsensusEngineId`. Each gossiping protocol should have a different one.
//! - Decide on a protocol name. Each gossiping protocol should have a different one.
//! - Build a `GossipEngine` using these three elements.
//! - Use the methods of the `GossipEngine` in order to send out messages and receive incoming
//! messages.
Expand Down