PR grumbles

bin/node/cli/Cargo.toml

@@ -116,7 +116,6 @@ sc-keystore = { version = "2.0.0", path = "../../../client/keystore" }
 sc-consensus = { version = "0.8.0", path = "../../../client/consensus/common" }
 sc-consensus-babe = { version = "0.8.0", features = ["test-helpers"], path = "../../../client/consensus/babe" }
 sc-consensus-epochs = { version = "0.8.0", path = "../../../client/consensus/epochs" }
-sc-consensus-manual-seal = { version = "0.8.0", path = "../../../client/consensus/manual-seal" }
 sc-service-test = { version = "2.0.0", path = "../../../client/service/test" }
 futures = "0.3.9"
 tempfile = "3.1.0"

bin/node/e2e-tests/Cargo.toml

@@ -3,6 +3,7 @@ name = "node-e2e-tests"
 version = "0.1.0"
 authors = ["Parity Technologies <[email protected]>"]
 edition = "2018"
+publish = false
 
 [dependencies]
 substrate-test-runner = { version = "0.8.0", path = "../../../test-utils/substrate-test-runner" }

bin/node/e2e-tests/src/lib.rs

@@ -1,3 +1,23 @@
+// This file is part of Substrate.
+
+// Copyright (C) 2020-2021 Parity Technologies (UK) Ltd.
+// SPDX-License-Identifier: GPL-3.0-or-later WITH Classpath-exception-2.0
+
+// This program is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License
+// along with this program. If not, see <https://www.gnu.org/licenses/>.
+
+//! End to end runtime tests
+
 use substrate_test_runner::{Node, ChainInfo, SignatureVerificationOverride};
 use grandpa::GrandpaBlockImport;
 use sc_service::{TFullBackend, TFullClient, Configuration, TaskManager, new_full_parts};
@@ -168,4 +188,4 @@ mod tests {
         force_transfer(&node);
 
     }
-}
+}

frame/babe/src/tests.rs

@@ -255,6 +255,11 @@ fn can_enact_next_config() {
 #[test]
 fn can_fetch_current_and_next_epoch_data() {
 	new_test_ext(5).execute_with(|| {
+		// genesis authorities should be used for the first and second epoch
+		assert_eq!(
+			Babe::current_epoch().authorities,
+			Babe::next_epoch().authorities,
+		);
 		// 1 era = 3 epochs
 		// 1 epoch = 3 slots
 		// Eras start from 0.

frame/balances/e2e-tests/Cargo.toml

@@ -3,6 +3,7 @@ name = "pallet-balances-e2e-tests"
 version = "2.0.0"
 authors = ["Parity Technologies <[email protected]>"]
 edition = "2018"
+publish = false
 
 [dependencies]
 pallet-sudo = { version = "2.0.0", path = "../../../frame/sudo" }

frame/balances/e2e-tests/src/lib.rs

@@ -16,6 +16,7 @@ type Extrinsic<R, S> = UncheckedExtrinsic<
     S,
 >;
 
+/// Tests the Balances::force_transfer call
 pub fn force_transfer<T>(node: &Node<T>)
     where
         T: ChainInfo,
@@ -63,6 +64,7 @@ pub fn force_transfer<T>(node: &Node<T>)
     assert_eq!(new_bob_balance, bob_balance + (balance))
 }
 
+/// Tests the Balances::set_balance call
 pub fn set_balance<T>(node: &Node<T>)
     where
         T: ChainInfo,
@@ -108,6 +110,7 @@ pub fn set_balance<T>(node: &Node<T>)
     assert_eq!(updated_bob_balance, alice_balance)
 }
 
+/// Tests the Balances::transfer_keep_alive call
 pub fn transfer_keep_alive<T>(node: &Node<T>)
     where
         T: ChainInfo,

frame/balances/src/lib.rs

@@ -151,8 +151,6 @@
 
 #[macro_use]
 mod tests;
-#[cfg(feature = "tests")]
-pub mod tests_e2e;
 mod tests_local;
 mod tests_composite;
 mod benchmarking;

test-utils/substrate-test-runner/Cargo.toml

@@ -1,7 +1,7 @@
 [package]
 name = "substrate-test-runner"
 version = "0.8.0"
-authors = ["Tomasz Drwięga <[email protected]>", "Seun Lanlege <[email protected]>"]
+authors = ["Parity Technologies <[email protected]>"]
 edition = "2018"
 
 [dependencies]

test-utils/substrate-test-runner/src/host_functions.rs

@@ -1,3 +1,21 @@
+// This file is part of Substrate.
+
+// Copyright (C) 2020-2021 Parity Technologies (UK) Ltd.
+// SPDX-License-Identifier: GPL-3.0-or-later WITH Classpath-exception-2.0
+
+// This program is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License
+// along with this program. If not, see <https://www.gnu.org/licenses/>.
+
 #[macro_export]
 macro_rules! override_host_functions {
     ($($fn_name:expr, $name:ident,)*) => {{

test-utils/substrate-test-runner/src/lib.rs

@@ -1,3 +1,21 @@
+// This file is part of Substrate.
+
+// Copyright (C) 2020-2021 Parity Technologies (UK) Ltd.
+// SPDX-License-Identifier: GPL-3.0-or-later WITH Classpath-exception-2.0
+
+// This program is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License
+// along with this program. If not, see <https://www.gnu.org/licenses/>.
+
 use manual_seal::consensus::ConsensusDataProvider;
 use sc_executor::NativeExecutionDispatch;
 use sc_service::{ChainSpec, Configuration, TFullBackend, TFullClient, TaskManager};
@@ -52,7 +70,7 @@ pub trait ChainInfo: Sized {
 
 	/// Get polkadot base path from env.
 	fn base_path() -> Option<String> {
-		std::env::var("POLKADOT_BASE_PATH").ok()
+		std::env::var("DB_BASE_PATH").ok()
 	}
 
 	/// Signed extras, this function is caled in an externalities provided environment.

test-utils/substrate-test-runner/src/node.rs

@@ -1,3 +1,21 @@
+// This file is part of Substrate.
+
+// Copyright (C) 2020-2021 Parity Technologies (UK) Ltd.
+// SPDX-License-Identifier: GPL-3.0-or-later WITH Classpath-exception-2.0
+
+// This program is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License
+// along with this program. If not, see <https://www.gnu.org/licenses/>.
+
 use std::{cell::RefCell, sync::Arc};
 
 use futures::{FutureExt, SinkExt, channel::{mpsc, oneshot}};

test-utils/substrate-test-runner/src/utils.rs

@@ -1,3 +1,21 @@
+// This file is part of Substrate.
+
+// Copyright (C) 2020-2021 Parity Technologies (UK) Ltd.
+// SPDX-License-Identifier: GPL-3.0-or-later WITH Classpath-exception-2.0
+
+// This program is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License
+// along with this program. If not, see <https://www.gnu.org/licenses/>.
+
 use crate::ChainInfo;
 use futures::{Sink, SinkExt};
 use sc_client_api::execution_extensions::ExecutionStrategies;
@@ -38,7 +56,7 @@ where
 	chain_spec.set_storage(storage);
 
 	let mut network_config = NetworkConfiguration::new(
-		format!("Polkadot Test Node for: {}", key_seed),
+		format!("Test Node for: {}", key_seed),
 		"network/test/0.1",
 		Default::default(),
 		None,
@@ -54,7 +72,7 @@ where
 	network_config.transport = TransportConfig::MemoryOnly;
 
 	Configuration {
-		impl_name: "polkadot-test-node".to_string(),
+		impl_name: "test-node".to_string(),
 		impl_version: "0.1".to_string(),
 		role,
 		task_executor,