Apply suggestions from code review

Co-authored-by: Kian Paimani <[email protected]>

Cargo.toml

@@ -6,7 +6,7 @@ members = [
 	"bin/node/bench",
 	"bin/node/browser-testing",
 	"bin/node/cli",
-    "bin/node/test-runner-example",
+	"bin/node/test-runner-example",
 	"bin/node/executor",
 	"bin/node/primitives",
 	"bin/node/rpc",

bin/node/test-runner-example/src/lib.rs

@@ -1,6 +1,6 @@
 // This file is part of Substrate.
 
-// Copyright (C) 2020-2021 Parity Technologies (UK) Ltd.
+// Copyright (C) 2021 Parity Technologies (UK) Ltd.
 // SPDX-License-Identifier: GPL-3.0-or-later WITH Classpath-exception-2.0
 
 // This program is free software: you can redistribute it and/or modify
@@ -231,7 +231,7 @@ impl ChainInfo for NodeTemplateChainInfo {
 
     fn dispatch_with_root(call: <Self::Runtime as frame_system::Config>::Call, node: &mut Node<Self>) {
         let alice = MultiSigner::from(Alice.public()).into_account();
-        let call = pallet_sudo::Call::sudo(Box::new(call)); // :D
+        let call = pallet_sudo::Call::sudo(Box::new(call));
         node.submit_extrinsic(call, alice);
         node.seal_blocks(1);
     }
@@ -240,7 +240,6 @@ impl ChainInfo for NodeTemplateChainInfo {
 #[cfg(test)]
 mod tests {
     use super::*;
-    use frame_system::{Call, Pallet};
 
     #[test]
     fn test_runner() {
@@ -249,10 +248,10 @@ mod tests {
         node.seal_blocks(1);
         // submit extrinsics
         let alice = MultiSigner::from(Alice.public()).into_account();
-        node.submit_extrinsic(Call::remark((b"hello world").to_vec()), alice);
+        node.submit_extrinsic(frame_system::Call::remark((b"hello world").to_vec()), alice);
 
-        // look ma, i can read state
-        let _events = node.with_state(|| Pallet::<node_runtime::Runtime>::events());
+        // look ma, I can read state.
+        let _events = node.with_state(|| frame_system::Pallet::<node_runtime::Runtime>::events());
         // get access to the underlying client.
         let _client = node.client();
     }

test-utils/test-runner/src/host_functions.rs

@@ -1,6 +1,6 @@
 // This file is part of Substrate.
 
-// Copyright (C) 2020-2021 Parity Technologies (UK) Ltd.
+// Copyright (C) 2021 Parity Technologies (UK) Ltd.
 // SPDX-License-Identifier: GPL-3.0-or-later WITH Classpath-exception-2.0
 
 // This program is free software: you can redistribute it and/or modify

test-utils/test-runner/src/node.rs

@@ -1,6 +1,6 @@
 // This file is part of Substrate.
 
-// Copyright (C) 2020-2021 Parity Technologies (UK) Ltd.
+// Copyright (C) 2021 Parity Technologies (UK) Ltd.
 // SPDX-License-Identifier: GPL-3.0-or-later WITH Classpath-exception-2.0
 
 // This program is free software: you can redistribute it and/or modify
@@ -84,7 +84,7 @@ pub struct Node<T: ChainInfo> {
 type EventRecord<T> = frame_system::EventRecord<<T as frame_system::Config>::Event, <T as frame_system::Config>::Hash>;
 
 impl<T: ChainInfo> Node<T> {
-	/// Starts a node with the manual-seal authorship,
+	/// Starts a node with the manual-seal authorship.
 	pub fn new() -> Result<Self, sc_service::Error>
 	where
 		<T::RuntimeApi as ConstructRuntimeApi<T::Block, TFullClient<T::Block, T::RuntimeApi, T::Executor>>>::RuntimeApi:
@@ -345,7 +345,7 @@ impl<T: ChainInfo> Node<T> {
 		}
 	}
 
-	/// Create a new jsonrpc client using the jsonrpc-core-client local transport
+	/// Create a new jsonrpc client using the jsonrpc-core-client local transport.
 	pub fn rpc_client<C>(&self) -> C
 	where
 		C: From<RpcChannel> + 'static,
@@ -357,12 +357,12 @@ impl<T: ChainInfo> Node<T> {
 		client
 	}
 
-	/// Revert count number of blocks from the chain
+	/// Revert count number of blocks from the chain.
 	pub fn revert_blocks(&self, count: NumberFor<T::Block>) {
 		self.backend.revert(count, true).expect("Failed to revert blocks: ");
 	}
 
-	/// Revert all blocks added since creation of the node
+	/// Revert all blocks added since creation of the node.
 	pub fn clean(&self) {
 		// if a db path was specified, revert all blocks we've added
 		if let Some(_) = base_path() {
@@ -371,7 +371,7 @@ impl<T: ChainInfo> Node<T> {
 		}
 	}
 
-	/// Performs a runtime upgrade given a wasm blob
+	/// Performs a runtime upgrade given a wasm blob.
 	pub fn upgrade_runtime(&mut self, wasm: Vec<u8>)
 		where
 			<T::Runtime as frame_system::Config>::Call: From<frame_system::Call<T::Runtime>>