Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Document caveats of send_request better.
  • Loading branch information
eskimor committed Feb 2, 2021
commit 12353465e3517248156d6ef7ea4203936eaa1a0a
4 changes: 3 additions & 1 deletion client/network/src/service.rs
Original file line number Diff line number Diff line change
Expand Up @@ -844,8 +844,10 @@ impl<B: BlockT + 'static, H: ExHashT> NetworkService<B, H> {
/// Variation of `request` which can connect to peers when necessary.
///
/// In some cases we do request data, without prior notification. For those cases this function
/// exists, it has no guarantees on connection staying alive, so you might still want to pass
/// exists. It has no guarantees on connection staying alive, so you might still want to pass
/// false to the `connect` parameter and ensure liveness of connections via peer sets.
/// Connecting to a peer can take up to several seconds, if a peer exposes multiple
/// addresses, but is only reachable by some of them, for example.
///
/// Apart from exposing whether or not we want to connect, in case of a disconnected peer, this
/// function also takes a sender for sending the response back, instead of returning the
Expand Down