Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Add a send_request function to NetworkService #8008

Merged
eskimor merged 17 commits into from
Feb 2, 2021
Merged

Add a send_request function to NetworkService #8008

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
554bbe7
Add a `send_request` to `NetworkService`.
eskimor Jan 28, 2021
1235346
Document caveats of send_request better.
eskimor Jan 28, 2021
479b15a
Fix compilation in certain cases.
eskimor Jan 29, 2021
3dd1369
Update docs + introduce IfDisconnected enum
eskimor Feb 1, 2021
36ac11b
Doc fix.
eskimor Feb 1, 2021
fe93ea7
Rename send_request to detached_request.
eskimor Feb 2, 2021
1781f01
Whitespace fix - arrrgh
eskimor Feb 2, 2021
5d8ec15
Update client/network/src/service.rs
eskimor Feb 2, 2021
8924872
Update client/network/src/request_responses.rs
eskimor Feb 2, 2021
bc46ded
Update client/network/src/service.rs
eskimor Feb 2, 2021
3d4d87c
Update client/network/src/service.rs
eskimor Feb 2, 2021
cf0b7a4
Update client/network/src/service.rs
eskimor Feb 2, 2021
a71e12f
Update client/network/src/service.rs
eskimor Feb 2, 2021
9c90a8f
Remove error in logs on dialing a peer.
eskimor Feb 2, 2021
05cf554
Rename detached_request to start_request.
eskimor Feb 2, 2021
8869176
Fix merged master.
eskimor Feb 2, 2021
d4f6baa
Fix too long lines.
eskimor Feb 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Doc fix.
  • Loading branch information
@eskimor
eskimor committed Feb 2, 2021
commit 36ac11b30e473a4da49290a2341b2b16e6f4b648
2 changes: 1 addition & 1 deletion client/network/src/request_responses.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ pub enum IfDisconnected {
ImmediateError,
}

/// Convenience functions for `IfDisconnectedBehaviour`.
/// Convenience functions for `IfDisconnected`.
impl IfDisconnected {
/// Shall we connect to a disconnected peer?
pub fn should_connect(self) -> bool {
Expand Down
2 changes: 1 addition & 1 deletion client/network/src/service.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -813,7 +813,7 @@ impl<B: BlockT + 'static, H: ExHashT> NetworkService<B, H> {
/// peer can announce something through a notification, after which the recipient can obtain
/// more information by performing a request.
/// As such, call this function with `IfDisconnected::ImmediateError` for `connect`. This way you
/// will get an error immediately for disconnected peers, instead of waiting a potentially very
/// will get an error immediately for disconnected peers, instead of waiting for a potentially very
/// long connection attempt, which would suggest that something is wrong anway, as you are
/// supposed to be connected because of the notification protocol.
///
Expand Down