Fixed issues where a nil parameter would cause a crash, added nullability specifiers #1130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bclassed with a mutable version of the class; we’d end up with an immutable version there and would crash when we tried to call the mutable-only methods
…-iOS-OSX # Conflicts: # Parse/Internal/Object/Subclassing/PFObjectSubclassingController.m
…t of production code anyway
|
Thanks for the PR, among all of the changes I have trouble identifying where the issue is. We're just merged the support for swift 3, so you should be probably fine rebasing and taking if from there. Can you please reopen a PR with just the fix and an appropriate description or a link to the issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.