Remove PFEventuallyQueueTestHelper because (1) it was causing memory leaks in production code #1188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leaks in production code, and (2) it wasn't actually used in any tests.
|
Can’t we just use macros so the test helper is included only in test builds? |
|
My initial thought was to only include the test helper on test builds. It doesn't seem to actually be used in any tests, though, so having it in doesn't seem to confer any benefit |
|
Seems that the build is passing correctly, so let's go with it! |
tkhoa87
added a commit
to notabasement/Parse-SDK-iOS-OSX
that referenced
this pull request
Sep 25, 2017
* master: ⚡ Release 1.15.3 Remove PFEventuallyQueueTestHelper because (1) it was causing memory leaks in production code, and (2) it wasn't actually used in any tests. (parse-community#1188) Fix some issues where nil was passed to a method requiring a non-nil parameter (parse-community#1187) Xcode 9 modernization (parse-community#1186) fixes issue affecting list of listeners (parse-community#1182)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and (2) it wasn't actually used in any tests.