util: systemp: set pipefail flag #322
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Genimage will currently exit with a success exit code when generating a cpio archive fails due to a missing `cpio` util. This is due to a pipe in the `systemp` call and the `pipefail` option not being set. See this issue[1] for mor information. Add a test that checks if genimage fails if the cpio util is missing (which it currently does not but should). [1]: pengutronix#320 Signed-off-by: Leonard Göhrs <[email protected]>
This ensures that the whole call to `systemp` fails if one commands in a command line consisting of multiple commands joined by pipes fails. This is for example relevant for the `cpio` backend, where the `cpio` command is called and its output is piped to `gzip`. If the `cpio` command fails or is not found at all a `.cpio.gz` file will be created containing just the gzip header and genimage will return a successful exit status anyways. This change assumes that all relevant `/bin/sh` implementations support the `-o pipefail` option. We know that at least bash, dash and busybox ash do. Signed-off-by: Leonard Göhrs <[email protected]>
Member
|
Ubuntu uses dash by default. dash learnt pipefail only recently in v0.5.13. Ubuntu 22.04 includes dash 0.5.11+git20210903+057cd650a4ed-3build1). Looks like this was backported in Ubuntu's 0.5.12-7, but Ubuntu 24.04 is still on 0.5.12-6ubuntu5. See also koalaman/shellcheck#2555 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR implements the change suggested in #320. It is a draftbecause the tests currently fail for at least Ubuntu 22.04 with the message:
/bin/sh: 0: Illegal option -o pipefail.This ensures that the whole call to
systempfails if one commands in a command line consisting of multiple commands joined by pipes fails.This is for example relevant for the
cpiobackend, where thecpiocommand is called and its output is piped togzip.If the
cpiocommand fails or is not found at all a.cpio.gzfile will be created containing just the gzip header and genimage will return a successful exit status anyways.This change assumes that all relevant
/bin/shimplementations support the-o pipefailoption. We know that at least bash, dash and busybox ash do.Fixes #320.