Skip to content

util: systemp: set pipefail flag #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hnez wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

util: systemp: set pipefail flag #322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbc4c51
test: cpio: add variant that should fail due to missing cpio util
hnez Dec 10, 2025
5043c36
util: systemp: set pipefail flag
hnez Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions test/filesystem.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ test_expect_success cpio "cpio" "
check_filelist
"

test_expect_failure "cpio missing" "
GENIMAGE_CPIO=/usr/bin/cpio-not-available run_genimage_root cpio.config test.cpio
"

exec_test_set_prereq mkfs.cramfs
test_expect_success mkfs_cramfs "cramfs" "
run_genimage_root cramfs.config test.cramfs &&
Expand Down
2 changes: 1 addition & 1 deletion util.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ int systemp(struct image *image, const char *fmt, ...)
if (!shell || shell[0] == 0x0)
shell = "/bin/sh";

execl(shell, shell, "-c", buf, NULL);
execl(shell, shell, "-o", "pipefail", "-c", buf, NULL);
ret = -errno;
error("Cannot execute %s: %s\n", buf, strerror(errno));
goto err_out;
Expand Down
Loading