-
Notifications
You must be signed in to change notification settings - Fork 360
refactor(pd): 🎬 pull grpc endpoint into penumbra-app
#3996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penumbra-apppenumbra-app
This was referenced Mar 11, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-mock-consensus
Area: Relates to the mock consensus engine
C-refactor
Category: refactors and other related improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #3913, #3973 and #3588. this is a second attempt, following up on #3980.
🔭 background
NB: the difference between this and #3679 is that the latter (which ran afoul of a regression) would have
penumbra-appcreate aRoutes, that we would add to the builder (which stays inpd). here, i'm not trying to make that cut betweenRouterandRoutes, and am attempting to hoist the whole thing out ofpd, without making changes to how we interact withtonic. my aim is for us to be able to move this, without running into that bug (#3697) again.NB: after running into problems in #3980, i found a way to easily reproduce the issue locally. my belief was that something related to our dependencies' cargo features was at play. rather than isolate the issue, it was easier to rewrite this (it's just code motion, after all) while running some of the network integration tests in a loop.
unlike #3980, this moves the rpc server into
penumbra-app, per #3980 (comment)👁️ overview
we would like to use the rust view server in mock consensus tests. in order to run the
penumbra_view::ViewServerhowever, we need to spin up the corresponding grpc endpoint for it to connect to.this branch performs a bit of code motion, moving the
grpc_serverout ofpdand intopenumbra-app. there will likely be other functional changes to the code in question before we can use it in those tests, but this PR is interested in moving that code into a place where our tests can rely upon it.