app: 📺 test that Planner can spend notes via mock consensus
#4471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cratelyn
added
C-enhancement
cratelyn
force-pushed
the
kate/view-server-tests-redux
branch
from
3d78c52 to
0d82c26
Compare
hdevalence
reviewed
May 29, 2024
cratelyn
force-pushed
the
kate/view-server-tests-redux
branch
from
0d82c26 to
4e43181
Compare
cratelyn
force-pushed
the
kate/view-server-tests-redux
branch
from
4e43181 to
44eb082
Compare
this commit introduces a new, optional component of the mock consensus test node. `on_block` is a `tendermint::Block -> ()` function that can be used to collect the blocks being generated by the test node.
cratelyn
force-pushed
the
kate/view-server-tests-redux
branch
from
44eb082 to
7e9e309
Compare
our broader goal is to wire up plumbing so that a test node can handle the tendermint proxy service client's requests sent by the view server when planning transactions. as a step towards that, add a new crate to the workspace. for the time being, we provide an empty `Stub` proxy. we will build upon this and sort out connecting it to a running `TestNode<C>` next.
- `axum-server` - `camino` - `penumbra-view` - `tower-http` - `url`
this import was defining an alias, and then using that alias to import other symbols.
we don't need to create a new connection every time we record a block. instead, use the `Channel` that the `ViewServer` sets up upon construction. refs: #3212
hoist the construction of a tonic channel out of the worker. move it to the call-side, in the view server.
cratelyn
force-pushed
the
kate/view-server-tests-redux
branch
from
7e9e309 to
99c6bb1
Compare
Contributor
Author
|
rebased on the latest main ♻️ |
Contributor
Author
|
...and ci passed! this should be ready for another look, when you have time @hdevalence 🙂 |
hdevalence
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💭 describe your changes
fixes #3913.
this is the exciting culmination of work in pr's #3996, #4349, #4435,
#4447, #4460, #4468, #4469, and #4470.
this adds a mock consensus test that spawns a gRPC server, creates a
view server, and then plans a transaction using the
Planner. theeffects of this are then observed using the
ViewClient.NB: this is a large branch, so i have broken this into various preliminary PR's. this should land after:
tendermint-*compatibility #4447these are related and included in this branch, but could land in parallel:
TransactionPlan::with_populated_detection_data()#4469TestNode<C>isSend + Sync#4470✅ checklist before requesting a review
if this code contains consensus-breaking changes, i have added the
"consensus-breaking" label. otherwise, i declare my belief that there are not
consensus-breaking changes, for the following reason:
🔗 related work
penumbra-app#3996ViewServicemethods #4435tendermint-*compatibility #4447rpc::router(..)accepts aTendermintProxyService#4460TransactionPlan::with_populated_detection_data()#4469TestNode<C>isSend + Sync#4470