Skip to content

Add PHPStan Static Analysis (Level Max + Strict Rules) #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Oct 14, 2025
Merged

Add PHPStan Static Analysis (Level Max + Strict Rules) #562

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
248f26f
feat: add PHPStan.
uzulla Oct 6, 2025
0e5d3ae
feat: improve type safety with PHPStan (590→0 errors)
uzulla Oct 6, 2025
ff5d41a
fix(PHPStan): store result of mb_encoding_aliases() for PHPStan warn.
uzulla Oct 6, 2025
efa32ce
feat: refactor Extractor classes to improve constructor dependency in…
uzulla Oct 6, 2025
783e7c2
refactor: improve empty string handling in adapter detectors for PHPS…
uzulla Oct 6, 2025
c14275a
fix: correct variable usage for extractor in AuthorUrl class
uzulla Oct 6, 2025
c128a80
fix: prevent meaningless ratio calculation for zero height in EmbedCode
uzulla Oct 6, 2025
a386551
test: use assertEqualsWithDelta for ratio calculations in EmbedCodeTest
uzulla Oct 6, 2025
fc1a6c9
fix: enhance owner and username checks to prevent empty string handli…
uzulla Oct 6, 2025
22de3cc
refactoring: improve token validation in OEmbed class to ensure prope…
uzulla Oct 6, 2025
cfa2b6d
refactoring: improve readable code.
uzulla Oct 6, 2025
77bf186
fix: ensure empty strings fallback to next metadata source in detectors
uzulla Oct 6, 2025
feaecea
fix: add unit tests for AuthorUrl detectors handling empty and zero s…
uzulla Oct 6, 2025
6bb8de9
fix: add trim() to adapter detectors for consistent whitespace handling
uzulla Oct 6, 2025
9a85f3f
Ignoring argument type
Vitorinox Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: use assertEqualsWithDelta for ratio calculations in EmbedCodeTest
  • Loading branch information
@uzulla
uzulla committed Oct 6, 2025
commit a386551fc847f31863e8ca4ec3afe11cbafef212
4 changes: 2 additions & 2 deletions tests/EmbedCodeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public function testRatioCalculationNormal()
{
// Normal case: width=380, height=120
$code = new EmbedCode('<iframe></iframe>', 380, 120);
$this->assertEquals(31.579, $code->ratio);
$this->assertEqualsWithDelta(31.579, $code->ratio, 0.001);
}

public function testRatioCalculationWithNullWidth()
Expand Down Expand Up @@ -65,7 +65,7 @@ public function testJsonSerialize()
$this->assertEquals('<div>test</div>', $json['html']);
$this->assertEquals(640, $json['width']);
$this->assertEquals(480, $json['height']);
$this->assertEquals(75.0, $json['ratio']);
$this->assertEqualsWithDelta(75.0, $json['ratio'], 0.001);
}

public function testToString()
Expand Down