Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactoring: improve readable code.
  • Loading branch information
uzulla committed Oct 6, 2025
commit cfa2b6de614b1e3949e71c4e3e085dd86b9cae56
2 changes: 1 addition & 1 deletion src/Adapters/Archive/Detectors/AuthorName.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@ public function detect(): ?string
$api = $extractor->getApi();

$result = $api->str('metadata', 'creator');
return ($result !== null && $result !== '') ? $result : parent::detect();
return (is_string($result) && $result !== '') ? $result : parent::detect();
}
}
2 changes: 1 addition & 1 deletion src/Adapters/Archive/Detectors/Description.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@ public function detect(): ?string
$api = $extractor->getApi();

$result = $api->str('metadata', 'extract');
return ($result !== null && $result !== '') ? $result : parent::detect();
return (is_string($result) && $result !== '') ? $result : parent::detect();
}
}
2 changes: 1 addition & 1 deletion src/Adapters/Archive/Detectors/Title.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@ public function detect(): ?string
$api = $extractor->getApi();

$result = $api->str('metadata', 'title');
return ($result !== null && $result !== '') ? $result : parent::detect();
return (is_string($result) && $result !== '') ? $result : parent::detect();
}
}
2 changes: 1 addition & 1 deletion src/Adapters/Gist/Detectors/AuthorName.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@ public function detect(): ?string
$api = $extractor->getApi();

$result = $api->str('owner');
return ($result !== null && $result !== '') ? $result : parent::detect();
return (is_string($result) && $result !== '') ? $result : parent::detect();
}
}
2 changes: 1 addition & 1 deletion src/Adapters/Gist/Detectors/AuthorUrl.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public function detect(): ?UriInterface
$api = $extractor->getApi();
$owner = $api->str('owner');

if ($owner !== null && $owner !== '') {
if (is_string($owner) && $owner !== '') {
return $extractor->getCrawler()->createUri("https://github.com/{$owner}");
}

Expand Down
2 changes: 1 addition & 1 deletion src/Adapters/ImageShack/Detectors/AuthorName.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@ public function detect(): ?string
$api = $extractor->getApi();

$result = $api->str('owner', 'username');
return ($result !== null && $result !== '') ? $result : parent::detect();
return (is_string($result) && $result !== '') ? $result : parent::detect();
}
}
2 changes: 1 addition & 1 deletion src/Adapters/ImageShack/Detectors/AuthorUrl.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public function detect(): ?UriInterface
$api = $extractor->getApi();
$owner = $api->str('owner', 'username');

if ($owner !== null && $owner !== '') {
if (is_string($owner) && $owner !== '') {
return $extractor->getCrawler()->createUri("https://imageshack.com/{$owner}");
}

Expand Down
2 changes: 1 addition & 1 deletion src/Adapters/ImageShack/Detectors/Description.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@ public function detect(): ?string
$api = $extractor->getApi();

$result = $api->str('description');
return ($result !== null && $result !== '') ? $result : parent::detect();
return (is_string($result) && $result !== '') ? $result : parent::detect();
}
}
2 changes: 1 addition & 1 deletion src/Adapters/ImageShack/Detectors/Title.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@ public function detect(): ?string
$api = $extractor->getApi();

$result = $api->str('title');
return ($result !== null && $result !== '') ? $result : parent::detect();
return (is_string($result) && $result !== '') ? $result : parent::detect();
}
}
2 changes: 1 addition & 1 deletion src/Adapters/Twitter/Detectors/AuthorName.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@ public function detect(): ?string
$api = $extractor->getApi();

$result = $api->str('includes', 'users', '0', 'name');
return ($result !== null && $result !== '') ? $result : parent::detect();
return (is_string($result) && $result !== '') ? $result : parent::detect();
}
}
2 changes: 1 addition & 1 deletion src/Adapters/Twitter/Detectors/AuthorUrl.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public function detect(): ?UriInterface
$api = $extractor->getApi();
$username = $api->str('includes', 'users', '0', 'username');

if ($username !== null && $username !== '') {
if (is_string($username) && $username !== '') {
return $extractor->getCrawler()->createUri("https://twitter.com/{$username}");
}

Expand Down
2 changes: 1 addition & 1 deletion src/Adapters/Twitter/Detectors/Description.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@ public function detect(): ?string
$api = $extractor->getApi();

$result = $api->str('data', 'text');
return ($result !== null && $result !== '') ? $result : parent::detect();
return (is_string($result) && $result !== '') ? $result : parent::detect();
}
}
2 changes: 1 addition & 1 deletion src/Adapters/Wikipedia/Detectors/Description.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@ public function detect(): ?string
$api = $extractor->getApi();

$result = $api->str('extract');
return ($result !== null && $result !== '') ? $result : parent::detect();
return (is_string($result) && $result !== '') ? $result : parent::detect();
}
}
2 changes: 1 addition & 1 deletion src/Adapters/Wikipedia/Detectors/Title.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@ public function detect(): ?string
$api = $extractor->getApi();

$result = $api->str('title');
return ($result !== null && $result !== '') ? $result : parent::detect();
return (is_string($result) && $result !== '') ? $result : parent::detect();
}
}