-
Notifications
You must be signed in to change notification settings - Fork 39
Async Http Client #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
d6b548c
Replace sendRequests with an async approach
joelwurtz 9b7bbf2
Force callback to be set
joelwurtz b6c5434
Use specification of promises/a+
joelwurtz 5628eee
Replace "should" by "must"
joelwurtz 1c569e7
Add documentation about states, add method to get value and reason of…
joelwurtz 5a868bd
Add note about promises/a+
joelwurtz 21e01c1
Fix typo on request <-> response
joelwurtz f2af5cb
Fix documentation from an user point of view
joelwurtz fe7d30b
Use string for constant, add wait method, add some documentation abou…
joelwurtz 55b159f
Fixing phpdoc, rename getError to getException
joelwurtz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
Fixing phpdoc, rename getError to getException
- Loading branch information
commit 55b159fe639e627d0824f13fde536009f4ad440f
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -38,7 +38,7 @@ interface Promise | |
| * The callback will be called when the response or exception arrived and never more than once. | ||
| * | ||
| * @param callable $onFulfilled Called when a response will be available. | ||
| * @param callable $onRejected Called when an error happens. | ||
| * @param callable $onRejected Called when an error happens. | ||
| * | ||
| * You must always return the Response in the interface or throw an Exception. | ||
| * | ||
|
|
@@ -56,27 +56,28 @@ public function getState(); | |
| /** | ||
| * Return the value of the promise (fulfilled). | ||
| * | ||
| * @throws \LogicException When the promise is not fulfilled. | ||
| * | ||
| * @return ResponseInterface Response Object only when the Promise is fulfilled. | ||
| * | ||
| * @throws \LogicException When the promise is not fulfilled. | ||
| */ | ||
| public function getResponse(); | ||
|
|
||
| /** | ||
| * Return the reason of the promise (rejected). | ||
| * | ||
| * @throws \LogicException When the promise is not rejected. | ||
| * | ||
| * @return Exception Exception Object only when the Promise is rejected. | ||
| * | ||
| * If the exception is an instance of Http\Client\Exception\HttpException it will contain | ||
| * the response object with the status code and the http reason. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i think this should go above the |
||
| * | ||
| * @throws \LogicException When the promise is not rejected. | ||
| */ | ||
| public function getError(); | ||
| public function getException(); | ||
|
|
||
| /** | ||
| * Wait for the promise to be fulfilled or rejected. | ||
| * | ||
| * This function does not return a result, it simply wait for response or error | ||
| * of the request to be available, change the state of the promise and call one | ||
| * of the then callable. | ||
| * When this method returns, the request has been resolved and the appropriate callable has terminated. | ||
| */ | ||
| public function wait(); | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Return the reason why the promise was rejected."?
and we could mention that if this exception is a HttpException, it will contain the Response object with the error status code inside. (in the hope that people will be less confused when trying to figure out how to get to that information)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you think about the wording "Get the reason why the promise was rejected." ?