Skip to content

Async Http Client #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

Async Http Client #77

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d6b548c
Replace sendRequests with an async approach
joelwurtz Oct 25, 2015
9b7bbf2
Force callback to be set
joelwurtz Oct 25, 2015
b6c5434
Use specification of promises/a+
joelwurtz Oct 26, 2015
5628eee
Replace "should" by "must"
joelwurtz Oct 26, 2015
1c569e7
Add documentation about states, add method to get value and reason of…
joelwurtz Oct 26, 2015
5a868bd
Add note about promises/a+
joelwurtz Oct 26, 2015
21e01c1
Fix typo on request <-> response
joelwurtz Oct 26, 2015
f2af5cb
Fix documentation from an user point of view
joelwurtz Oct 29, 2015
fe7d30b
Use string for constant, add wait method, add some documentation abou…
joelwurtz Oct 31, 2015
55b159f
Fixing phpdoc, rename getError to getException
joelwurtz Nov 4, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Replace "should" by "must"
  • Loading branch information
@joelwurtz
joelwurtz committed Nov 4, 2015
commit 5628eee8510535e3fe55ac7de9d416643fa333d8
4 changes: 2 additions & 2 deletions src/Promise.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@ interface Promise
* @param callable $onFulfilled Called when a response will be available.
*
* It will receive a Psr\Http\Message\RequestInterface object as the first argument
* If the callback is null it should not be called.
* If the callback is null it must not be called.
*
* @param callable $onRejected Called when an error happens.
*
* It will receive a Http\Client\Exception object as the first argument.
* If the callback is null it should not be called.
* If the callback is null it must not be called.
*
* @return Promise Always returns a new promise which is resolved with value of the executed callback (onFulfilled / onRejected)
*/
Expand Down