Skip to content

Conversation

@codynova
Copy link
Member

Fix #1642

Why

The Notification Hub useTransition example persists notifications when clicking to "cancel" after onRest. In this scenario, the "cancel" function cancels the leave animation.

What

Ensure that "cancel" is not called during the leave animation by checking the value of the life prop when clicking the "x" button

Checklist

  • Documentation updated
  • Demo added
  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 22, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f6e1b2c:

Sandbox Source
spring-card Configuration
spring-goo-blobs Configuration
spring-flip-card Configuration
spring-slide Configuration
spring-draggable-list Configuration
spring-cards-stack Configuration
spring-viewpager Configuration
spring-simple-transition Configuration
spring-image-fade Configuration
spring-list-reordering Configuration
spring-masonry Configuration
spring-animating-auto Configuration
spring-multistage-transition Configuration
spring-chain Configuration
spring-svg-filter Configuration
spring-css-keyframes Configuration
spring-tree Configuration
spring-notification-hub Configuration
initial-rocket Configuration
spring-notification-hub Configuration
spring-notification-hub Configuration
spring-notification-hub Issue #1642

Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! ⭐

@joshuaellis joshuaellis merged commit 48e17fa into master Aug 4, 2021
@joshuaellis joshuaellis deleted the bugfix/1642 branch August 4, 2021 21:20
cameron-martin pushed a commit to cameron-martin/react-spring that referenced this pull request May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Notification Hub useTransition example persists notifications when clicking to "cancel" after onRest

3 participants