Skip to content

fix: resolve #1642 Notification Hub demo cancelling messages after on… #1643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2021
Merged

fix: resolve #1642 Notification Hub demo cancelling messages after on… #1643

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47bec1a
fix: resolve #1642 Notification Hub demo cancelling messages after on…
Jul 22, 2021
f6e1b2c
Merge branch 'master' into bugfix/1642
joshuaellis Aug 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions demo/src/sandboxes/notification-hub/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ function MessageHub({
})
)
},
config: (item, index, phase) => key => (phase === 'enter' && key === 'life' ? { duration: timeout } : config),
config: (item, index, phase) => key => phase === 'enter' && key === 'life' ? { duration: timeout } : config,
})

useEffect(() => {
Expand All @@ -67,7 +67,7 @@ function MessageHub({
<Button
onClick={(e: MouseEvent) => {
e.stopPropagation()
if (cancelMap.has(item)) cancelMap.get(item)()
if (cancelMap.has(item) && life.get() !== '0%') cancelMap.get(item)()
}}>
<X size={18} />
</Button>
Expand Down