Update ss58 page #466
Merged
Update ss58 page #466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuke-web3
added
bug 🐛
Co-authored-by: Sacha Lansky <[email protected]>
Co-authored-by: Sacha Lansky <[email protected]>
nuke-web3
commented
Nov 8, 2021
| For production networks, however, a network-specific version may be desirable to help avoid the key-reuse between networks and some of the problems that it can cause. | ||
| Substrate nodes will default to printing keys in address type 42, though alternative Substrate-based node implementations (e.g. Polkadot) may elect to default to some other type. | ||
|
|
||
| ### Address Formats for Substrate |
Contributor
Author
There was a problem hiding this comment.
Is the below table (only edits for format) wrong ? I see https://paritytech.github.io/substrate/master/src/sp_core/crypto.rs.html#245 has 2 bytes for all formats...?
nuke-web3
commented
Nov 8, 2021
| | 15 | 1 | 8 | 6 | | ||
| | 16 | 1 | 8 | 7 | | ||
| | 17 | 1 | 8 | 8 | | ||
| | 34 | 1 | 32 | 2 | |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| | 34 | 1 | 32 | 2 | | |
| | 35 | 1 | 32 | 2 | |
Not sure what is right here, but needs to add up
apopiak
reviewed
Nov 9, 2021
sacha-l
approved these changes
Nov 9, 2021
This was referenced Nov 9, 2021
This was referenced Nov 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor and polish of the page overall, it was missing most of the content in the archive of the old wiki that has no other home and should live here. Missed in #105
closes #114
Outstanding items before done: