Skip to content

Conversation

@koushiro
Copy link
Collaborator

@koushiro koushiro commented May 12, 2023

@koushiro koushiro requested a review from sorpaas as a code owner May 12, 2023 08:36
koushiro added 2 commits May 12, 2023 17:52
- update substrate to 16b2e644487f7f767eeefd4debf11a7948bfa4db
- update rust toolchain to 1.68.2
…f `pallet-evm`,

since `ExistentialDeposit: u64 = 0` is configured in the mock impl of `pallet-evm`.
@koushiro
Copy link
Collaborator Author

I'm not sure whether we need to set ExistentialDeposit: u64 = 0 and enable insecure_zero_ed feature of pallet-balances for template runtime to compatible with Ethereum.

@koushiro koushiro mentioned this pull request May 24, 2023
@koushiro
Copy link
Collaborator Author

koushiro commented Jun 27, 2023

@sorpaas maybe we could merge this PR first?

And shall we set ExistentialDeposit: u64 = 0 and enable insecure_zero_ed feature of pallet-balances for template runtime to compatible with Ethereum?

@arturgontijo
Copy link
Contributor

Can we also have a polkadot-v0.9.42 branch for it? =)

ethereum-types = { version = "0.14.1", default-features = false }
evm = { git = "https://github.com/rust-blockchain/evm", branch = "master", default-features = false }
hex-literal = { version = "0.3.4" }
evm = { git = "https://github.com/rust-blockchain/evm", rev = "b7b82c7e1fc57b7449d6dfa6826600de37cc1e65", default-features = false }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah missed that. Thanks!

@sorpaas sorpaas merged commit e89f336 into polkadot-evm:master Jun 28, 2023
@koushiro koushiro deleted the update-polkadot-v0.9.42 branch June 28, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants