Skip to content

Conversation

@koushiro
Copy link
Collaborator

@koushiro koushiro commented Jun 14, 2023

  • update substrate to 3c8666b1906680ad9461a6c46fe17439629ab082
  • update some deps to the latest
  • update rust-toolchain.toml: rustc 1.69.0 (84c898d65 2023-04-16) / rustc 1.71.0-nightly (8b4b20836 2023-05-22)

Close #1054 or merge it first

@koushiro koushiro requested a review from sorpaas as a code owner June 14, 2023 11:47
@koushiro koushiro changed the title deps: update substrate to polkadot v0.9.43 deps: update substrate to polkadot-v0.9.43 Jun 14, 2023
@sorpaas
Copy link
Member

sorpaas commented Jun 26, 2023

Please resolve conflicts.

@koushiro
Copy link
Collaborator Author

the sql tests of mapping-sync failed
cc @tgmichel @nbaztec

@sorpaas maybe we could merge polkadot-v0.9.42 PR first?

@nbaztec
Copy link
Contributor

nbaztec commented Jun 29, 2023

the sql tests of mapping-sync failed cc @tgmichel @nbaztec

@sorpaas maybe we could merge polkadot-v0.9.42 PR first?

I checked and seems the error is here https://github.com/paritytech/frontier/blob/master/client/db/src/sql/mod.rs#L344

the code cannot find any logs for the block hashes so doesn't insert anything.

@tgmichel
Copy link
Contributor

@nbaztec @koushiro I think I know how to fix this, checking it

@tgmichel
Copy link
Contributor

tgmichel commented Jun 29, 2023

@koushiro please cherry pick from moonbeam-foundation@24f95bc

The issue was we are injecting the pallet-ethereum Digest directly into the BlockBuilder block constructor, and with recent changes in substrate-test-runtime that is no longer possible, as Executive checks will be run over the block we are trying to produce, making it fail because the Digest storage is empty..

Instead we need to use the new push_deposit_log_digest_item, which will push the digest to frame system storage, which in turn will make Executive final_checks to pass.

@sorpaas sorpaas merged commit 3c75079 into polkadot-evm:master Jul 3, 2023
@koushiro koushiro deleted the update-polkadot-v0.9.43 branch July 4, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants