Embedded file support for Prawn documents #1214
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gettalong
reviewed
Jul 21, 2021
gettalong
reviewed
Jul 21, 2021
dvdalilue
commented
Jul 21, 2021
gettalong
reviewed
Jul 22, 2021
gettalong
reviewed
Jul 22, 2021
gettalong
reviewed
Jul 22, 2021
Member
|
Okay, I think there is nothing to do here for the time being without the rest of the functionality as per the comments. |
pointlessone
requested changes
Jul 22, 2021
Member
pointlessone
left a comment
pointlessone
left a comment
There was a problem hiding this comment.
I would love some tests.
Member
|
Thank you for your contribution. This is a great start. |
gettalong
reviewed
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on pdf-core PR 47
This PR defines a new module that allows attaching files (or data) into the generated documents. The module relies on two classes, each one describes a pdf object needed to embed files, the
FilespecandEmbeddedFileobjects.The tests and documentation are missing but I'm working on the second one while updating the pdf-core PR 47 with some tests. Then I'll focus on this PR more deeply.