Skip to content

Embedded file support for Prawn documents #1214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dvdalilue wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Embedded file support for Prawn documents #1214

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
3ecc701
EmbeddedFile PDF object definition
dvdalilue Jul 21, 2021
375f85e
Filespec PDF object definition
dvdalilue Jul 21, 2021
83a0642
Document file attachment method definition
dvdalilue Jul 21, 2021
9461d98
EmbeddedFiles module included in Prawn::Document class and lib
dvdalilue Jul 21, 2021
0fb2b56
Creation and modification dates from file information
dvdalilue Jul 21, 2021
334c19a
:hidden option simplification
dvdalilue Jul 21, 2021
5680677
:hidden option could be a truthy value
dvdalilue Jul 22, 2021
6796763
Look for the Time class in the object's superclasses as well
dvdalilue Jul 22, 2021
ca63634
Using MD5 digest instead of the hex-encoded one
dvdalilue Jul 22, 2021
b96039b
Avoiding wasteful duplication
dvdalilue Jul 22, 2021
f41ed2c
Checksum attribute renamed
dvdalilue Jul 22, 2021
f0c0453
Filespec description key set wrongly fixed
dvdalilue Jul 22, 2021
a6343c1
Avoiding instance variables outside method
dvdalilue Jul 22, 2021
fe64860
Honoring document compression option
dvdalilue Jul 22, 2021
8d4e047
Avoiding changes of parameters
dvdalilue Jul 22, 2021
484d701
Using hex-encoded digest as default name
dvdalilue Jul 23, 2021
097ee85
Setting 'UF' entry in the 'EF' dictionary as well
dvdalilue Jul 23, 2021
8f09896
'file' method documentation
dvdalilue Jul 27, 2021
5d3011e
File registration refactor
dvdalilue Jul 27, 2021
3714d59
'is_a?' is preferable to 'kind_of?'
dvdalilue Aug 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
File registration refactor
  • Loading branch information
@dvdalilue
dvdalilue committed Jul 27, 2021
commit 5d3011e9521dbb93c497ceda7b5a4a325b2bbc41
12 changes: 8 additions & 4 deletions lib/prawn/embedded_files.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,12 @@ def file(src, options = {})
data = src
end

@file_registry ||= {}

file = EmbeddedFile.new(data, mut_opts)
file_obj = @file_registry[file.checksum]
file_obj = file_registry[file.checksum]

if file_obj.nil?
file_obj = file.build_pdf_object(self)
@file_registry[file.checksum] = file_obj
file_registry[file.checksum] = file_obj
end

filespec = Filespec.new(file_obj, mut_opts)
Expand All @@ -63,6 +61,12 @@ def file(src, options = {})
# attach_file(filespec.file_name, filespec_obj)
end
end

private

def file_registry
@file_registry ||= {}
end
end
end

Expand Down