Skip to content

fix(types) move static firestore interface to where it's implemented #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2020
Merged

fix(types) move static firestore interface to where it's implemented #1013

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da2cc07
Move the FirestoreStatics interface to where it's actually implemente…
zozoens31 Oct 8, 2020
b13b3ff
Merge branch 'v3.8.0' into firestore-statics
prescottprue Nov 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ interface BaseExtendedFirebaseInstance
ExtendedStorageInstance {
initializeAuth: VoidFunction

firestore: () => ExtendedFirestoreInstance
firestore: (() => ExtendedFirestoreInstance) & FirestoreStatics

dispatch: Dispatch

Expand Down Expand Up @@ -479,8 +479,7 @@ export type ReduxFirestoreQueriesFunction = (
* @see https://github.com/prescottprue/redux-firestore#api
*/
interface ExtendedFirestoreInstance
extends FirestoreTypes.FirebaseFirestore,
FirestoreStatics {
extends FirestoreTypes.FirebaseFirestore {
/**
* Get data from firestore.
* @see https://github.com/prescottprue/redux-firestore#get
Expand Down