fix(types) move static firestore interface to where it's implemented #1013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d by Firebase. Closes prescottprue#1012
Codecov Report
@@ Coverage Diff @@
## v3.8.0 #1013 +/- ##
=========================================
Coverage ? 88.37%
=========================================
Files ? 29
Lines ? 800
Branches ? 0
=========================================
Hits ? 707
Misses ? 93
Partials ? 0 |
|
Will get this into the next release after testing it a bit more, thanks for the PR! |
Hi, Any update about the release? I really need to access FieldValue static! Actually, we can't ... Thanks |
prescottprue
added a commit
that referenced
this pull request
Nov 18, 2020
* feat(auth): enable claims without userProfile (#1008) - @rscotten * fix(types): add arguments to types for onAuthStateChanged (#1018) - @AlexanderArvidsson * fix(auth): dispatch proper error on reset password (#1016) - @djejaquino * fix(types) move static firestore interface to where it's implemented (#1013) - @zozoens31 * feat(auth): add applyActionCode method (#994) - @komachi Co-authored-by: Richard Scotten <[email protected]> Co-authored-by: Alexander Arvidsson <[email protected]> Co-authored-by: Davi Aquino <[email protected]> Co-authored-by: Cyrille Corpet <[email protected]> Co-authored-by: Anton Nesterov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See the linked issue: This fixes how Typescript describes the static elements of
firestoreas implemented by Firebase.Check List
If not relevant to pull request, check off as complete
Relevant Issues
#1012
This change is