Skip to content

Conversation

@AlexanderArvidsson
Copy link
Contributor

@AlexanderArvidsson AlexanderArvidsson commented Oct 24, 2020

Description

Check List

If not relevant to pull request, check off as complete

  • All tests passing
  • Docs updated with any changes or examples if applicable
  • Added tests to ensure new feature(s) work properly

Relevant Issues

@codecov
Copy link

codecov bot commented Oct 24, 2020

Codecov Report

Merging #1018 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1018      +/-   ##
==========================================
+ Coverage   88.33%   88.34%   +0.01%     
==========================================
  Files          29       29              
  Lines         797      798       +1     
==========================================
+ Hits          704      705       +1     
  Misses         93       93              

@prescottprue prescottprue changed the title Fix typings for onAuthStateChanged fix(types): add arguments to types for onAuthStateChanged Nov 17, 2020
@prescottprue prescottprue changed the base branch from master to v3.8.0 November 17, 2020 22:59
@prescottprue prescottprue merged commit 17b87d0 into prescottprue:v3.8.0 Nov 17, 2020
@prescottprue prescottprue mentioned this pull request Nov 17, 2020
3 tasks
prescottprue added a commit that referenced this pull request Nov 18, 2020
* feat(auth): enable claims without userProfile (#1008) - @rscotten
* fix(types): add arguments to types for onAuthStateChanged (#1018) - @AlexanderArvidsson
* fix(auth): dispatch proper error on reset password (#1016) - @djejaquino
* fix(types) move static firestore interface to where it's implemented (#1013) - @zozoens31
* feat(auth): add applyActionCode method (#994) - @komachi

Co-authored-by: Richard Scotten <[email protected]>
Co-authored-by: Alexander Arvidsson <[email protected]>
Co-authored-by: Davi Aquino <[email protected]>
Co-authored-by: Cyrille Corpet <[email protected]>
Co-authored-by: Anton Nesterov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants