Fix createUserProfile on login with Facebook #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prescottprue
reviewed
Jul 7, 2017
|
|
||
| // For email auth return uid (createUser is used for creating a profile) | ||
| if (userData.email) return userData.uid | ||
| if (method === 'signInWithEmailAndPassword') return userData.uid |
There was a problem hiding this comment.
Nice! Exactly what I was thinking.
This was referenced Jul 10, 2017
Merged
prescottprue
added a commit
that referenced
this pull request
Jul 14, 2017
* Node v8 support (`package.lock.json` added, and `8` added to node versions in travis config) * `credential` support for login method - #186 * createUserProfile called with Facebook authentication - #187 * Switched back to using constructor to set context vars (attempt to fix undefined vars in component mount) * Merged changes that set `displayName` and `wrappedComponent` * Docs sections `redux-observable` and `epics` combined * Docs updated with changes to compose function (no longer supports passing fbConfig) * Docs added about `presence` and `sessions` config options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user logs in with Facebook, the userData is in the following format:
there is no
userinuserDataso it was failing creating the profile. This pr fixes that.