Skip to content

Conversation

@prescottprue
Copy link
Owner

@prescottprue prescottprue commented Jul 10, 2017

Description

  • logout method supports credential parameter (with matching docs and tests updates)
  • createFirebaseConnect is now exported at top level (for creating firebaseConnect connected to different store)
  • .npmignore expanded to include more files that do not needed to be included in published version (including .babelrc which can cause build errors)
  • .babelrc settings are now environment specific (decorators only used in testing)
  • babel-preset-stage-1 removed (unnecessary)
  • tests folder now has its own .eslintrc which contains globals that are only necessary for testing (simplifies top level eslint config)
  • deprecation warning added for token and provider combo in login method
  • Docs added for storeAs and keyProp

Check List

If not relevant to pull request, check off as complete

  • All tests passing
  • Docs updated with any changes or examples
  • Added tests to ensure feature(s) work properly

Relevant Issues

Scott Prue added 7 commits July 10, 2017 00:34
* Export createFirebaseConnect
* Rename connect.js to firebaseConnect.js (for clarity)
* env specific babel config added (decorators only used in testing)
* .eslintrc added to tests folder (has globals needed only for testing)
* `.npmignore` now includes other files not needed in published version
(some files cause build errors such as  `.babelrc`)
* `stage-1` babel transform removed
* deprecation warning added for provider + token combo in login method
@prescottprue prescottprue merged commit 9d6a4ca into v1.5.0 Jul 11, 2017
@prescottprue prescottprue deleted the v1.5.0-rc.1 branch July 11, 2017 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants