Skip to content

feat(firebaseConnect): expose wrapped component and displayName #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 10, 2017
Merged

feat(firebaseConnect): expose wrapped component and displayName #188

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dbc2a46
Expose WrappedComponent on Connected component
JustinTulloss Jul 9, 2017
81ca0e1
Merge branch 'master' into expose-wrapped-and-displayname
JustinTulloss Jul 9, 2017
1e24097
A more robust method for getting the display component name
JustinTulloss Jul 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
A more robust method for getting the display component name
  • Loading branch information
@JustinTulloss
JustinTulloss committed Jul 9, 2017
commit 1e240972cbde825e06dc19994b13d9d893be28df
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@
"immutable": "^3.8.1",
"jwt-decode": "^2.2.0",
"lodash": "^4.17.4",
"opencollective": "^1.0.3"
"opencollective": "^1.0.3",
"react-display-name": "^0.2.0"
},
"peerDependencies": {
"react": "^0.14.6 || ^15.0.0"
Expand Down
3 changes: 2 additions & 1 deletion src/connect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import React, { Component, PropTypes } from 'react'
import getDisplayName from 'react-display-name'
import { isEqual } from 'lodash'
import hoistStatics from 'hoist-non-react-statics'
import { watchEvents, unWatchEvents } from './actions/query'
Expand Down Expand Up @@ -58,7 +59,7 @@ export default (dataOrFn = []) => WrappedComponent => {
store: PropTypes.object.isRequired
};

static displayName = `FirebaseConnect(${WrappedComponent.displayName}`;
static displayName = `FirebaseConnect(${getDisplayName(WrappedComponent)}`;
static WrappedComponent = WrappedComponent;

componentWillMount () {
Expand Down