feat(firebaseConnect): expose wrapped component and displayName #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allows for easier testing by passing in props directly - Follows the same convention that react-redux uses
JustinTulloss
changed the title
Codecov Report
@@ Coverage Diff @@
## master #188 +/- ##
==========================================
+ Coverage 85.83% 85.89% +0.05%
==========================================
Files 17 17
Lines 1483 1489 +6
Branches 246 246
==========================================
+ Hits 1273 1279 +6
Misses 210 210 |
prescottprue
changed the title
Owner
|
Great addition. Will release in |
Owner
|
Released with matching tests in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds two statics to a connected component:
WrappedComponent, which is the original component. This is useful for testing without mocking out firebase.displayNameis set to reveal what component is wrapped by FirebaseConnect. This makes debugging easier.This will require a new version (presumably 1.4.4) but is purely additive and therefore should not break any existing code, unless people were relying on the previous behavior of
displayName.Check List
If not relevant to pull request, check off as complete