Skip to content

Conversation

@prescottprue
Copy link
Owner

Description

  • Adds two statics to a connected component:
    • wrappedComponent, which is the original component (useful for testing without mocking firebase)
    • displayName is set to reveal what component is wrapped by FirebaseConnect. This makes debugging easier
  • Tests added for both new statics listed above
  • Remove open collective as a dependency (not used in postinstall)

Check List

  • All tests passing
  • Docs updated with any changes or examples
  • Added tests to ensure feature(s) work properly

Relevant Issues

Scott Prue and others added 3 commits July 9, 2017 22:40
Adds two statics to a connected component:
- `WrappedComponent`, which is the original component. This is useful for testing without mocking out firebase.
- `displayName` is set to reveal what component is wrapped by FirebaseConnect. This makes debugging easier.
…ective from dependencies.

* Remove open collective from dependencies
* Add tests for displayName and wrappedComponent
@prescottprue prescottprue self-assigned this Jul 10, 2017
@codecov
Copy link

codecov bot commented Jul 10, 2017

Codecov Report

Merging #189 into master will increase coverage by 0.18%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
+ Coverage   85.83%   86.02%   +0.18%     
==========================================
  Files          17       17              
  Lines        1483     1488       +5     
  Branches      246      246              
==========================================
+ Hits         1273     1280       +7     
+ Misses        210      208       -2

@prescottprue prescottprue merged commit 17a9b99 into master Jul 10, 2017
@prescottprue prescottprue deleted the v1.4.4 branch July 10, 2017 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants