Add getValueAt function for easy migration to v2 from dataToJS and pathToJS #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prescottprue
requested changes
Oct 24, 2017
src/helpers.js
Outdated
| } | ||
|
|
||
| const dotPath = getDotStrPath(path) | ||
| const valueAtPath = get(firebase, dotPath) |
There was a problem hiding this comment.
We should also have the notSetValue be passed here so it is used as the defaultValue:
return get(firebase, dotPath, notSetValue)
prescottprue
approved these changes
Oct 24, 2017
prescottprue
added a commit
that referenced
this pull request
Oct 24, 2017
* feat(core): `recompose` used for `withFirebase` and `withFirestore` HOCs * feat(core): `promiseEvents` method added. Similar to `firebaseConnect`, but not a React Higher Order Component - #299 - thanks @marekolszewski * feat(core): `redux-firestore` is no longer included and is now an optionalDependency (increased bundle size too much) * feat(helpers): `getVal` added to simplify migration from v1 to v2 (can easily replace `dataToJS`) - #305 - thanks @fej-snikduj * feat(reducer): added error to clearly indicate wrong initial state being passed to `errors` state * feat(reducer): `preserve` now supports passing an object to preserve `auth`, `profile`, `errors`, and `ordered` * feat(docs): Firestore setup instructions switched to using `redux-firestore` externally * feat(examples): firestore example uses `redux-firestore` directly (since it is no longer included) * fix(typings): remove an artifact from a previous merge conflict - #304 - thanks @cbellino * fix(reducer): `authError` state is now `null` by default (tests changed to match) * fix(examples): examples all point to `next` tag for consistency * fix(examples): snippets README.md files updated * fix(examples): `tests` folder removed from material example ### Potentially Breaking * `authError` state is now `null` by default instead of `{}` - this is more clear, and more closely resembles `v1.*.*`
prescottprue
pushed a commit
that referenced
this pull request
Oct 25, 2017
* Migration guide updated with info about auth state and `getVal` - #305
prescottprue
added a commit
that referenced
this pull request
Oct 26, 2017
* fix(reducers): add `EMPTY_AUTH_CHANGE` case to Profile Reducer - #305 * feat(constants): `enableEmptyAuthChanges` config option replaced by `preserveOnEmptyAuthChange` - #305 * feat(profile): `autoPopulateProfile` support for v2 (still `disabled` by default) * fix(presence): support presence option on `react-native-firebase` versions without `setPriority` on `RNFirebase.database.ThenableReference` - #267 * fix(core): withFirebase now works for all main methods * feat(examples): material example updated to be much more simple (uses mostly functional components over classes) * feat(docs): `promiseEvents` added to SSR docs - #299
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check List
If not relevant to pull request, check off as complete
Relevant Issues