Skip to content

Add getValueAt function for easy migration to v2 from dataToJS and pathToJS #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 24, 2017
Merged

Add getValueAt function for easy migration to v2 from dataToJS and pathToJS #305

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4e1ed33
Add getValueAt function
fej-snikduj Oct 24, 2017
488fd93
Change name of data to firebase
fej-snikduj Oct 24, 2017
34d1303
Remove regex
fej-snikduj Oct 24, 2017
7f3b69e
Add example
fej-snikduj Oct 24, 2017
f400a1d
Add default value at rename getValueAt to getVal
fej-snikduj Oct 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change name of data to firebase
  • Loading branch information
@fej-snikduj
fej-snikduj committed Oct 24, 2017
commit 488fd9321b95ffb3cf562f7a709e2dfae40312b8
12 changes: 4 additions & 8 deletions src/helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,20 +51,16 @@ import { getDotStrPath } from './reducer'
* todos: getValueAt(firebase, 'data/todos/user1', defaultValue)
* })
*/
export const getValueAt = (data, path, notSetValue) => {
if (!data) {
export const getValueAt = (firebase, path, notSetValue) => {
if (!firebase) {
return notSetValue
}

const pathArr = `/${fixPath(path)}`.split(/\//).slice(1)
const dotPath = getDotStrPath(pathArr)
const valueAtPath = get(data, dotPath)
const valueAtPath = get(firebase, dotPath)
Copy link
Owner

@prescottprue prescottprue Oct 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also have the notSetValue be passed here so it is used as the defaultValue:

return get(firebase, dotPath, notSetValue)


if (has(data, dotPath)) {
return get(data, dotPath)
}

return data
return valueAtPath
}

/**
Expand Down