v2.0.0-rc.1 #358
Merged
v2.0.0-rc.1 #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…337 * exposed reducer (matches common redux panther also seen with other libraries such as redux-form)
Codecov Report
@@ Coverage Diff @@
## v2.0.0 #358 +/- ##
=========================================
+ Coverage 82.81% 84.61% +1.8%
=========================================
Files 22 23 +1
Lines 2281 2386 +105
Branches 350 362 +12
=========================================
+ Hits 1889 2019 +130
+ Misses 392 367 -25 |
…tion. package-lock updated. * dispatch added to withFirebase * Fix double dispatch of FILE_UPLOAD_START when using progress: true option * transform-decorators-legacy removed (no longer used in tests)
prescottprue
force-pushed
the
v2.0.0-rc.1
branch
from
288759f to
404c7c7
Compare
* reducer file split into utils and reducers file * mocha options moved to mocha.opts file * tests folder renamed to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
withContextfromwithFirebaseandwithFirestorein order to support reactv16.*.*- bug(withFirebase): "Warning: Failed child context type..." when using react v16 #337props.dispatchadded towithFirebasereducerasreducerto match common redux panther also seen with otherlibraries such as
redux-formprogress: trueoption on upload would cause dispatch ofFILE_UPLOAD_STARTto occur twicebabel-transform-decorators-legacyremoved from dependencies (no longer used in tests)recomposeis now a dev dependency only (no longer used in HOCs as part of fix for bug(withFirebase): "Warning: Failed child context type..." when using react v16 #337)Check List
If not relevant to pull request, check off as complete
Relevant Issues