Skip to content

v2.0.0-rc.1 #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 17, 2017
Merged

v2.0.0-rc.1 #358

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e050457
Removed recompose's withContext from withFirebase and withFirestore -…
prescottprue Dec 11, 2017
759a1b1
Tests added for withFirestore.
Dec 12, 2017
472aa66
Fix double dispatch of FILE_UPLOAD_START when using progress: true op…
prescottprue Dec 12, 2017
404c7c7
A few more test updates.
prescottprue Dec 12, 2017
df31841
withFirestore and withFirebase docs updated
prescottprue Dec 14, 2017
ea28179
recompose is not longer a dependency (now a dev dependency)
prescottprue Dec 17, 2017
c5d36de
Moved babel require out of mocha.opts back into npm script (does not …
prescottprue Dec 17, 2017
a3c7b11
ignore mocha opts from eslint.
prescottprue Dec 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
A few more test updates.
  • Loading branch information
@prescottprue
prescottprue committed Dec 12, 2017
commit 404c7c79f1e5952f79893cae911a4cee4863ef29
1 change: 0 additions & 1 deletion tests/unit/actions/storage.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ let spy
let unListen = sinon.spy()
const dispatch = () => {}
const defaultFileMeta = { path: 'projects', file: { name: 'test.png' } }
let dispatchSpy
const fakeFirebase = {
_: {
authUid: '123',
Expand Down
19 changes: 12 additions & 7 deletions tests/unit/firestoreConnect.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,11 @@ const createContainer = () => {
}

describe('firestoreConnect', () => {
it('should render if Firestore does not exist', () => {
const { container } = createContainer()
// TODO: Pass a fake store through context
expect(container).to.exist
})
it('should receive the store in the context', () => {
const { container, store } = createContainer()
expect(container.context.store).to.equal(store)
Expand All @@ -37,16 +42,16 @@ describe('firestoreConnect', () => {
expect(container.context.store).to.equal(store)
})

it('does not change watchers props changes that do not change listener paths', () => {
const { container, store } = createContainer()
container.setState({ test: 'somethingElse' })
expect(container.context.store).to.equal(store)
it('does not change watchers with props changes that do not change listener paths', () => {
const { parent, container } = createContainer()
parent.setState({ test: 'somethingElse' })
expect(container.prevData).to.be.null
})

it('reapplies watchers when props change', () => {
const { container, store } = createContainer()
container.setState({ dynamic: 'somethingElse' })
expect(container.context.store).to.equal(store)
const { parent, container } = createContainer()
parent.setState({ dynamic: 'somethingElse' })
expect(container.prevData).to.be.null
})

describe('sets displayName static as ', () => {
Expand Down