Skip to content

Conversation

@prescottprue
Copy link
Owner

@prescottprue prescottprue commented Feb 1, 2017

@codecov-io
Copy link

Codecov Report

Merging #52 into master will increase coverage by 1.45%.

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
+ Coverage   87.69%   89.14%   +1.45%     
==========================================
  Files          17       17              
  Lines        1243     1253      +10     
  Branches      193      195       +2     
==========================================
+ Hits         1090     1117      +27     
+ Misses        153      136      -17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 366c4ff...5ef2b26. Read the comment docs.

@prescottprue prescottprue merged commit 8811cda into master Feb 1, 2017
@prescottprue prescottprue deleted the v1.2.3 branch February 1, 2017 22:27
@prescottprue prescottprue mentioned this pull request Mar 26, 2017
prescottprue added a commit that referenced this pull request Mar 26, 2017
### Breaking Changes
* react-native is now used differently in config when creating store which breaks `v1.4.0-alpha` ("rn" was not as clear as "ReactNative"). Use the following config when creating store:
  ```js
  import { reactReduxFirebase } from 'react-redux-firebase'
  import { AsyncStorage } from 'react-native'
  const fbConfig = {} // your firebase config object
  reactReduxFirebase(fbConfig, {
    ReactNative: { AsyncStorage }  // now under "ReactNative" instead of "rn"
    // enableRedirectHandling: false // no longer needed
  })
  ```
* firebase library imported using `import * as firebase from 'firebase'` instead of piece by piece to fix Unsupported Browser error from `v1.4.0-alpha` (thanks @kudorori - full details in #87). Could have impact on #52, #72, or #80.

### Features
* [react-native complete example](https://github.com/prescottprue/react-redux-firebase/tree/v1.4.0-beta/examples/complete/react-native) added showing authentication
* firebase library updated to `v3.7.3`
* Package quality image added to README
* Docs updated with react-native changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants