Skip to content

Conversation

@prescottprue
Copy link
Owner

@prescottprue prescottprue commented Mar 26, 2017

Breaking Changes

  • react-native is now used differently in config when creating store which breaks v1.4.0-alpha ("rn" was not as clear as "ReactNative"). Use the following config when creating store:
    import { reactReduxFirebase } from 'react-redux-firebase'
    import { AsyncStorage } from 'react-native'
    const fbConfig = {} // your firebase config object
    reactReduxFirebase(fbConfig, {
      ReactNative: { AsyncStorage }  // now under "ReactNative" instead of "rn"
      // enableRedirectHandling: false // no longer needed
    })
  • firebase library imported using import * as firebase from 'firebase' instead of piece by piece to fix Unsupported Browser error from v1.4.0-alpha (thanks @kudorori - full details in use auth signInWithCredential login Error #87). Could have impact on Version v1.2.3 #52 or I.hasOwnProperty("process") #80.

Features

  • react-native complete example added showing authentication
  • firebase library updated to v3.7.3
  • Package quality image added to README
  • Docs updated with react-native changes

@codecov
Copy link

codecov bot commented Mar 26, 2017

Codecov Report

Merging #97 into master will decrease coverage by 0.36%.
The diff coverage is 86.95%.

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
- Coverage   88.81%   88.45%   -0.37%     
==========================================
  Files          17       17              
  Lines        1368     1377       +9     
  Branches      225      226       +1     
==========================================
+ Hits         1215     1218       +3     
- Misses        153      159       +6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3102af...8c40703. Read the comment docs.

@prescottprue prescottprue changed the base branch from master to v1.4.0 March 26, 2017 10:58
@prescottprue prescottprue merged commit d65aa2f into v1.4.0 Mar 26, 2017
@prescottprue prescottprue deleted the v1.4.0-beta branch March 26, 2017 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants