Skip to content

Addresses issue #6587 #6665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Garima3110 wants to merge 37 commits into
base: main
Choose a base branch
from
Draft

Addresses issue #6587 #6665

Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
227fe69
Extending p5.texture for cubemap textures
Garima3110 Dec 24, 2023
8e2d05c
Merge remote-tracking branch 'upstream/main' into cubeMap
Garima3110 Dec 25, 2023
317d915
Merge remote-tracking branch 'upstream/main' into cubeMap
Garima3110 Dec 28, 2023
917de2f
Added vertex and fragment shaders for cubemaps
Garima3110 Dec 28, 2023
5139c0a
Updated src/webgl/shaders/lighting.glsl file for cubemaps
Garima3110 Dec 28, 2023
45e33d5
Storing the diffuse irradiance in a cubemap texture
Garima3110 Dec 28, 2023
1d54fad
Added caching mechanism for shaders
Garima3110 Dec 29, 2023
1ff8702
Updated caching for some shaders
Garima3110 Dec 29, 2023
6cd7856
Updated p5.Texture.js
Garima3110 Dec 29, 2023
4401ebd
Updated cubeVertex and cubeFragment shaders
Garima3110 Dec 29, 2023
37751d9
renamed cubemap shader files
Garima3110 Dec 29, 2023
93b8b50
Updated p5.RendererGL.js
Garima3110 Dec 29, 2023
66dc0dc
Updated p5.Texture.js
Garima3110 Dec 29, 2023
cffda69
Updated lighting.glsl
Garima3110 Dec 29, 2023
751b16a
Added TEXTURE_CUBE
Garima3110 Dec 29, 2023
29e7a14
Added gl.SAMPLER_CUBE uniform type to p5.Shader.js
Garima3110 Dec 29, 2023
7981fdc
Merge remote-tracking branch 'upstream/main' into cubeMap
Garima3110 Dec 31, 2023
e7cd392
Minor changes in SAMPLER_CUBE uniform type
Garima3110 Dec 31, 2023
f30af0e
Minor updates on caching shaders
Garima3110 Dec 31, 2023
d51c4a8
Merge branch 'processing:main' into cubeMap
Garima3110 Jan 4, 2024
38bcaab
Merge branch 'processing:main' into cubeMap
Garima3110 Jan 8, 2024
2558755
Merge remote-tracking branch 'upstream/main' into cubeMap
Garima3110 Jan 13, 2024
773198a
Updated RendererGL.js
Garima3110 Jan 13, 2024
bbc7c72
Merge remote-tracking branch 'upstream/main' into cubeMap
Garima3110 Jan 15, 2024
ffd9097
Reordered some code in p5.RendererGL.js
Garima3110 Jan 16, 2024
cc77e7e
Minor fixes
Garima3110 Jan 20, 2024
518b0f0
Merge remote-tracking branch 'upstream/main' into cubeMap
Garima3110 Jan 20, 2024
c124738
Fragment shader error fixed
Garima3110 Jan 23, 2024
38e6e84
Merge remote-tracking branch 'upstream/main' into cubeMap
Garima3110 Jan 23, 2024
a585ef5
Minor updates
Garima3110 Jan 23, 2024
f118a3b
some fixes
Garima3110 Jan 24, 2024
2da03d1
Merge branch 'processing:main' into cubeMap
Garima3110 Jan 29, 2024
5961be8
Minor changes
Garima3110 Mar 30, 2024
4515c09
Some changes with cubemap implementation
Garima3110 Jun 20, 2024
be6d27f
Minor changes
Garima3110 Jun 24, 2024
6dc9916
fix
Garima3110 Jun 24, 2024
3133e80
Merge branch 'processing:main' into cubeMap
Garima3110 Nov 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Updated p5.RendererGL.js
  • Loading branch information
@Garima3110
Garima3110 committed Dec 29, 2023
commit 93b8b50dee0320dc5c346504aad2822a9796ed1e
31 changes: 21 additions & 10 deletions src/webgl/p5.RendererGL.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,6 @@ const webgl2CompatibilityShader = getCachedShader('webgl2CompatibilityShader',re
join(__dirname, '/shaders/webgl2Compatibility.glsl'),
'utf-8'
));
const cubemapFragmentShader=getCachedShader('cubemapFragmentShader',readFileSync(
join(__dirname,'/shaders/cubeFragment.glsl'),
'utf8'
));
const cubemapVertexShader=getCachedShader('cubemapVertexShader',readFileSync(
join(__dirname,'/shaders/cubeVertex.glsl'),
'utf8'
));

const defaultShaders = {
immediateVert: getCachedShader('immediateVert',readFileSync(
Expand Down Expand Up @@ -118,6 +110,12 @@ const defaultShaders = {
)),
imageLightSpecularFrag:getCachedShader('imageLightSpecularFrag', readFileSync(
join(__dirname, '/shaders/imageLightSpecular.frag'), 'utf-8'
)),
cubemapVertexShader:getCachedShader('cubemapVertexShader',readFileSync(
join(__dirname,'/shaders/cubeVertex.vert'),'utf8'
)),
cubemapFragmentShader:getCachedShader('cubemapFragmentShader',readFileSync(
join(__dirname,'/shaders/cubeFragment.frag'),'utf8'
))
};
for (const key in defaultShaders) {
Expand Down Expand Up @@ -1881,6 +1879,19 @@ p5.RendererGL = class RendererGL extends p5.Renderer {
return this._defaultFontShader;
}

_getCubemapShader() {
if (!this._defaultCubemapShader) {
this._defaultCubemapShader = new p5.Shader(
this,
this._webGL2CompatibilityPrefix('vert', 'mediump') +
defaultShaders.cubemapVertexShader,
this._webGL2CompatibilityPrefix('frag', 'mediump') +
defaultShaders.cubemapFragmentShader
);
}
return this._defaultCubemapShader;
}

_webGL2CompatibilityPrefix(
shaderType,
floatPrecision
Expand Down Expand Up @@ -1958,8 +1969,8 @@ p5.RendererGL = class RendererGL extends p5.Renderer {
}
// Create a shader for cubemap conversion
const cubemapShader = this._pInst.createShader(
Copy link
Contributor

@davepagurek davepagurek Dec 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just above this, we create and cache a shader so that we only ever need one copy. Can we add that caching here too?

Copy link
Member Author

@Garima3110 Garima3110 Dec 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have applied caching mechanism to possibly all the shaders. I am not sure whether this aligns with what you were suggesting through this @davepagurek .PLease have a look into the changes I've made.
Thanks.!

Copy link
Contributor

@davepagurek davepagurek Dec 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't want to wrap all the existing shader sources in a caching function, since those are just the sources for one part of a shader (e.g. just the vertex or fragment source, and often not the full source either, since we need to add a prefix to it.) A caching function would be good for this createShader call (since you're still creating a new shader every time this line is hit, currently.) A few lines up, this.diffusedShader already does caching, but can be refactored to use the same caching system you use here if you're factoring that out into a common pattern.

Copy link
Contributor

@davepagurek davepagurek Dec 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh actually I see that you've added that in _getCubemapShader. I think rather than making a new shader here, we can just use const cubemapShader = this._getCubemapShader() instead.

cubemapVertexShader,
cubemapFragmentShader);
defaultShaders.cubemapVertexShader,
defaultShaders.cubemapFragmentShader);

// Render each face of the cubemap
for (let i = 0; i < 6; ++i) {
Expand Down