Skip to content

Adds geometry to downloadable obj files functionality #6812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 23, 2024
Merged

Adds geometry to downloadable obj files functionality #6812

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b211f73
Adds geometry to downloadable obj files functionality
diyaayay Feb 15, 2024
778bc40
changes function name to saveObj
diyaayay Feb 16, 2024
2578053
using downloadFile instead of save and added documentation
diyaayay Feb 16, 2024
5773158
unit test and minor fix
diyaayay Feb 16, 2024
0a9cf53
Update p5.Geometry.js
dgrantham01 Jun 21, 2024
003af34
Merge branch 'main' into Downloadable-obj-file
davepagurek Jun 23, 2024
6302061
Update documentation, fix typos
davepagurek Jun 23, 2024
5b915f1
Add describe()
davepagurek Jun 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
unit test and minor fix
  • Loading branch information
@diyaayay
diyaayay committed Feb 16, 2024
commit 5773158d983e52122ec43f41da725db6fbc7e401
2 changes: 1 addition & 1 deletion src/webgl/p5.Geometry.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ p5.Geometry = class Geometry {
objStr += `f ${faceStr}\n`;
});

const blob = new Blob([objStr], { type: 'text/obj' });
const blob = new Blob([objStr], { type: 'text/plain' });
p5.prototype.downloadFile(blob, fileName , 'obj');

}
Expand Down
113 changes: 113 additions & 0 deletions test/unit/io/saveModel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,113 @@
suite('saveModel',function() {
var myp5;
setup(function(done) {
new p5(function(p) {
p.setup = function() {
myp5 = p;
done();
};
});
});
teardown(function() {
myp5.remove();
});
testWithDownload(
'should download an .obj file with expected contents',
async function(blobContainer) {
//.obj content as a string
const objContent = `v 100 0 0
v 0 -100 0
v 0 0 -100
v 0 100 0
v 100 0 0
v 0 0 -100
v 0 100 0
v 0 0 100
v 100 0 0
v 0 100 0
v 0 0 -100
v -100 0 0
v -100 0 0
v 0 -100 0
v 0 0 100
v 0 0 -100
v 0 -100 0
v -100 0 0
v 0 100 0
v -100 0 0
v 0 0 100
v 0 0 100
v 0 -100 0
v 100 0 0
vt 0 0
vt 0 0
vt 0 0
vt 0 0
vt 0 0
vt 0 0
vt 0 0
vt 0 0
vt 0 0
vt 0 0
vt 0 0
vt 0 0
vt 0 0
vt 0 0
vt 0 0
vt 0 0
vt 0 0
vt 0 0
vt 0 0
vt 0 0
vt 0 0
vt 0 0
vt 0 0
vt 0 0
vn 0 0 1
vn 0 0 1
vn 0 0 1
vn 0 0 1
vn 0 0 1
vn 0 0 1
vn 0 0 1
vn 0 0 1
vn 0 0 1
vn 0 0 1
vn 0 0 1
vn 0 0 1
vn 0 0 1
vn 0 0 1
vn 0 0 1
vn 0 0 1
vn 0 0 1
vn 0 0 1
vn 0 0 1
vn 0 0 1
vn 0 0 1
vn 0 0 1
vn 0 0 1
vn 0 0 1
f 1 2 3
f 4 5 6
f 7 8 9
f 10 11 12
f 13 14 15
f 16 17 18
f 19 20 21
f 22 23 24
`;

const objBlob = new Blob([objContent], { type: 'text/plain' });

myp5.downloadFile(objBlob, 'model', 'obj');

let myBlob = blobContainer.blob;

let text = await myBlob.text();

assert.strictEqual(text, objContent);
},
true
);

});