Check the element type before calling createRadio from select()
#6838
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only call
createRadiofromselect()if the element is a valid radio parent (span or div)Resolves #6836
Changes:
Adds a check
(elt.tagName === 'DIV' || elt.tagName === 'SPAN')before callingcreateRadio. Other element types will just get a normalp5.Element.I chose the
elt.tagName ===syntax because that is what is used in the lines above this. Note thatcreateRadiouses aninstanceofcheck (arg0.elt instanceof HTMLDivElement || arg0.elt instanceof HTMLSpanElement), but the result should be the same.PR Checklist
npm run lintpasses