Skip to content

Check the element type before calling createRadio from select() #6838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2024
Merged

Check the element type before calling createRadio from select() #6838

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Only call createRadio from select() if the element is a valid rad… 
…io parent
  • Loading branch information
@lindapaiste
lindapaiste committed Mar 9, 2024
commit edf11fb5cdd74710dcd42caf3eba2bc71dac6209
3 changes: 2 additions & 1 deletion src/dom/dom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,8 @@ p5.prototype._wrapElement = function (elt) {
children.length > 0 &&
children.every(function (c) {
return c.tagName === 'INPUT' || c.tagName === 'LABEL';
})
}) &&
(elt.tagName === 'DIV' || elt.tagName === 'SPAN')
) {
return this.createRadio(new p5.Element(elt, this));
} else {
Expand Down