loadFilterShader fixes #7636
Merged
loadFilterShader fixes #7636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perminder-17
commented
Mar 15, 2025
| * | ||
| * async function setup() { | ||
| * myShader = await loadFilterShader('assets/shader.frag'); | ||
| * myShader = await loadFilterShader('assets/basic.frag'); |
Collaborator
Author
There was a problem hiding this comment.
there were some linking issue with vertex shader from shader.frag, so using basic.frag
davepagurek
approved these changes
Mar 15, 2025
Contributor
davepagurek
left a comment
davepagurek
left a comment
There was a problem hiding this comment.
Thanks for catching this, I thought we removed all instances of it but I guess we missed this one!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the docs with loadFilterShaders, I noticed a bug saying
t._validateParameters is not a function.Not adding a parameters validation fixes the issue.