Add unit tests and travis-ci support #113
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch includes some very basic and initial unit testing using rspec-puppet and for the case of facts, just normal rspec. I've taken a very light approach here as rspec-puppet can be quite combinatorial when one gets carried away. For now I've just added basic compile failure detection effectively for classes and defined resources. As we continue to work on the code and find regressions this work can be expanded. For facts and functions I've also taken a basic approach for now. One little thing I did change, was the strange string that the fact returns when the default version is undefined. Instead of an error message I've just returned the string 'unknown' which is more in line with other facts I've seen in the wild, and to be quite honest 'unknown' is fairly self-explantory. Since a fact isn't an error reporting message this seemed more appropriate, and looked nicer in the rspec test. As far as travis-ci support, I've added the same configuration that @jmmcune came up with for stdlib which is pretty light and reasonable standard now we propogated that to 4 or so other modules in the puppetlabs/ namespace. It should work out of the box. Signed-off-by: Ken Barber <[email protected]>
Contributor
Author
|
Actually I just realised this doesn't include the fact tests. I'm going to do a small refactor and re-issue this pull request when its ready. |
Contributor
Contributor
Author
|
@razorsedge yeah I noticed. I wanted to pull it out into its own piece for my own purposing - and my intention was to comment on #91 after the fact. Cheers :-). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch includes some very basic and initial unit testing using rspec-puppet
and for the case of facts, just normal rspec.
I've taken a very light approach here as rspec-puppet can be quite combinatorial
when one gets carried away. For now I've just added basic compile failure
detection effectively for classes and defined resources. As we continue to work
on the code and find regressions this work can be expanded.
For facts and functions I've also taken a basic approach for now.
One little thing I did change, was the strange string that the fact returns
when the default version is undefined. Instead of an error message I've just
returned the string 'unknown' which is more in line with other facts I've seen
in the wild, and to be quite honest 'unknown' is fairly self-explantory. Since
a fact isn't an error reporting message this seemed more appropriate, and looked
nicer in the rspec test.
As far as travis-ci support, I've added the same configuration that @jmmcune
came up with for stdlib which is pretty light and reasonable standard now we
propogated that to 4 or so other modules in the puppetlabs/ namespace. It should
work out of the box.
Signed-off-by: Ken Barber [email protected]