Feature/jdbc #91
Feature/jdbc #91
Conversation
Modify params.pp to abstract the package name for the postgresql JDBC connector and add Class['postgresql::java']. Also update the README.md to mention the availability of this class.
This test conforms to the rspec-puppet and puppetlabs_spec_helper standards.
Conflicts: README.md
|
@cprice-puppet |
|
running the tests now via rake. Wondering if there is a reason that the contents of the rakefile can't just be placed inside of spec_helper.rb, though, so that tests can be run simply using rspec directly. I'm guessing there are some "best practices" here that you are probably adhering to and I'm not, though :) @branan you know more about this kind of stuff than I do, care to weigh in on pros/cons of Rakefile for this kind of thing? |
|
@razorsedge : so, when I run "rake spec", your tests pass. That's good. However, that doesn't seem to even attempt to run the Vagrant specs. When I run "rspec ./spec", which is how I've been running the vagrant specs, it tries to run both yours and the Vagrant ones. Yours fail in that case (presumably because they need the stuff from the Rakefile). I think we do need to either be able to separate them into two separate runs or have a way to run all of them in one fell swoop and have them pass. Once we get that worked out I'd like to merge this. |
|
@cprice-puppet : That was my big worry: how the puppetlabs_spec_helper method was going to impact the vagrantfile method. :( I fear that merging them may be over my head. |
|
And I'm not opposed to ripping the puppetlabs_spec_helper bits out and doing it the Vagrant way. |
|
@razorsedge : ok, I'll just amend the pull when I get a chance. I honestly think that moving the stuff from the Rakefile into spec_helper.rb would probably solve the problem but I'd like to pick @branan 's brain on the topic first. Thanks! Also, the good news (totally unsurprising) is that I did run through all of the Vagrant tests and they are all still passing, so we can merge this as soon as we sort this spec_helper/Rakefile stuff. |
|
@razorsedge okay dude ... if you're ready to rebase this one, the travis + rspec stuff is now merged into master. Thanks. |
3 participants
Added PostgreSQL JDBC support. This includes an rspec test that conforms to and requires the puppetlabs_spec_helper framework.