Requesthandler ignore missing devices logging #2749
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running a modbus server with the
ignore_missing_devices
flag set to True, the server will not send errors when clients request a wrong id (from the perspective of the server).However, there's an error log before the flag check:
This error level log leads to a unexpected error spam in the pymodbus module.
To my understanding of this flag, the expected behavior would be for the requesthandler to ignore all packages that is not meant for the server id, which means this is not an error level logging case.
The PR moves the error log after the
ignore_missing_devices
check and adds a debug level log inside theif
block.