Skip to content

Requesthandler ignore missing devices logging #2749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 26, 2025
Merged

Requesthandler ignore missing devices logging #2749

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e76c46
error log after ignore_missing_devices check
sebastianpetersenmove Aug 26, 2025
68f573c
added debug log inside ignore_missing_devices if block
sebastianpetersenmove Aug 26, 2025
bc2b1ac
Logging should be lowercase
sebastianpetersenmove Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pymodbus/server/requesthandler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,10 @@ async def handle_request(self):
response = await self.last_pdu.update_datastore(context)

except NoSuchIdException:
Log.error("requested device id does not exist: {}", self.last_pdu.dev_id)
if self.server.ignore_missing_devices:
Log.debug("ignoring request for unknown device id: {}", self.last_pdu.dev_id)
return # the client will simply timeout waiting for a response
Log.error("requested device id does not exist: {}", self.last_pdu.dev_id)
response = ExceptionResponse(self.last_pdu.function_code, ExcCodes.GATEWAY_NO_RESPONSE)
except Exception as exc: # pylint: disable=broad-except
Log.error(
Expand Down