Skip to content

Fixing endianness in Payload example. #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 9, 2018
Merged

Fixing endianness in Payload example. #350

merged 4 commits into from
Oct 9, 2018

Conversation

@EricDuminil
Copy link
Contributor

@EricDuminil EricDuminil commented Oct 8, 2018

builder and decoder don't have the same byteorder in this example:
https://pymodbus.readthedocs.io/en/latest/source/example/modbus_payload.html

64float comes out as 1.0489227558190733e+146 instead of 123.45

My commits set both byteorder to Endian.Big. and 64float is decoded to 123.45 again.

@dhoomakethu
Copy link
Contributor

dhoomakethu commented Oct 9, 2018

@EricDuminil Thanks for the PR.

@dhoomakethu dhoomakethu merged commit 826a76c into pymodbus-dev:dev Oct 9, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dhoomakethu dhoomakethu dhoomakethu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@EricDuminil @dhoomakethu