Skip to content

Fixing endianness in Payload example. #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 9, 2018
Merged

Fixing endianness in Payload example. #350

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fa724ab
Merge pull request #342 from riptideio/dev
dhoomakethu Sep 27, 2018
f0edef3
Merge pull request #348 from riptideio/dev
dhoomakethu Oct 3, 2018
0fce5b5
Adding asserts for Payload Endianness
EricDuminil Oct 8, 2018
3838f5f
Fixing example of Payload. Same Endianness for builder and decoder.
EricDuminil Oct 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion examples/common/modbus_payload.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,9 +125,16 @@ def run_binary_payload_ex():
print(result.registers)
print("\n")
decoder = BinaryPayloadDecoder.fromRegisters(result.registers,
byteorder=Endian.Little,
byteorder=Endian.Big,
wordorder=Endian.Little)

assert decoder._byteorder == builder._byteorder, \
"Make sure byteorder is consistent between BinaryPayloadBuilder and BinaryPayloadDecoder"

assert decoder._wordorder == builder._wordorder, \
"Make sure wordorder is consistent between BinaryPayloadBuilder and BinaryPayloadDecoder"


decoded = OrderedDict([
('string', decoder.decode_string(8)),
('bits', decoder.decode_bits()),
Expand Down